-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): Updated Index and Tutorial docs #456
base: main
Are you sure you want to change the base?
chore(docs): Updated Index and Tutorial docs #456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both pages look great -- thank you for working on them!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions, LGTM thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test coverage for 4f3f253
Static code analysis report
|
Enable the ingress on MicroK8s first: | ||
|
||
```bash | ||
sudo microk8s enable ingress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it was mentioned as a requirement, do you think this step is needed?
- NGINX Ingress Controller. If you're using [MicroK8s](https://microk8s.io/), this can be done by running the command `microk8s enable ingress`. For more details, see [Addon: Ingress](https://microk8s.io/docs/addon-ingress). | ||
|
||
For more information about how to install Juju, see [Get started with Juju](https://juju.is/docs/olm/get-started-with-juju). | ||
|
||
### Shell into the Multipass VM | ||
|
||
To be able to work inside the Multipass VM first you need to log in with the following command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here about Multipass VM not being mentioned as a requirement.
Applicable spec:
Overview
Standarise the Indico tutorial with other tutorials and improve/fix the tutorial.
Update the Indico
index.md
to standardise it with the other charms.Rationale
Juju Events Changes
Module Changes
Library Changes
Checklist
src-docs
urgent
,trivial
,complex
)