Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Prometheus exporters along with the application #291

Merged
merged 10 commits into from
Aug 10, 2023

Conversation

gtrkiller
Copy link
Contributor

Delete the exporter container and install them as snaps in the Indico image.

@gtrkiller gtrkiller requested a review from a team as a code owner July 26, 2023 14:08
@gtrkiller gtrkiller marked this pull request as draft July 26, 2023 14:08
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 91 files.

Valid Invalid Ignored Fixed
30 1 60 0
Click to see the invalid file list
  • install.sh

install.sh Outdated Show resolved Hide resolved
@gtrkiller gtrkiller marked this pull request as ready for review August 3, 2023 19:53
pyproject.toml Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
merkata
merkata previously approved these changes Aug 4, 2023
Copy link
Contributor

@merkata merkata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart of what David commented on, nothing to add.

amandahla
amandahla previously approved these changes Aug 9, 2023
Copy link
Contributor

@amandahla amandahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Just wanted to see if the images are too much bigger or not than before.

@github-actions
Copy link
Contributor

Test coverage for bc5cf92

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py     330      9     90     12    95%   127->exit, 143, 147, 512->exit, 559->562, 652->691, 793-794, 856->exit, 876->892, 878->887, 887->892, 900-901, 949->exit, 987-993
----------------------------------------------------------
TOTAL            330      9     90     12    95%

Static code analysis report

Run started:2023-08-10 12:08:50.735670

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 2119
  Total lines skipped (#nosec): 4
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@gtrkiller gtrkiller merged commit 76a9260 into main Aug 10, 2023
21 of 22 checks passed
@gtrkiller gtrkiller deleted the relocate_exporters branch August 10, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants