Add scenario check for LP 2017748 #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasbock
approved these changes
Sep 25, 2024
zhhuabj
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
lgtm
I tested it, this is my test result - https://pastebin.canonical.com/p/KCmrsBC4JX/
pponnuvel
approved these changes
Sep 26, 2024
| input: | ||
| path: 'var/log/neutron/neutron-ovn-metadata-agent.log' | ||
| search: | ||
| expr: '([\d-]+ [\d:]+.\d{3}) .+neutron.agent.ovn.metadata.agent \[-\] There is no metadata port for network \S+ or it has no MAC or IP addresses configured, tearing the namespace down if needed' |
There was a problem hiding this comment.
Is it possible to skip the "date" part? The rest of the strings would uniquely match in order to catch the issue. I know the log lines would have to have the timestamp for "constraints" to work but it's not necessary we regex it, right? Possibly a tiny improvement in compiling the regex is all.
This isn't unique to this scenario. But broadly applicable to most scenarios.
There was a problem hiding this comment.
The short answer is no, this is necessary and the reason is because of the use here of "extra" constraints. See
for a more in-depth explanation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.