-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial documentation for reactive mode #397
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # docs/changelog.md
This reverts commit 231dc13.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of the doc changes 👍
(Not giving an official approval since tox.ini
was also changed.)
Test coverage for 1be246b
Static code analysis report
|
|
||
### GitHub Runner flavors | ||
|
||
For this how-to-guide, we decided to have deployed three runner flavors: `large`, `large-arm`, `small` . We need |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it confusing the concept of runner flavor
. A runner (an openstack intance) will be associated to a flavor, but we will deploy a github-runner application, that will manage runners
with that flavor (at least for now, until github-runner applications handle several flavors).
The routing table, as far as I understand, routes labels to github-runner applications (of course, if they are not correctly configured it will not work correctly).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the architecture, not sure is that is related to an openstack flavor
, but related to the type of image and hypervisors. If that is the case, then architecture is just part of the concept of flavor, but different to openstack flavor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javierdelapuente runner flavor == runner application
. Would a rename to github runner application
resolve your confusion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that will make it clearer!
Applicable spec: ISD-116
Overview
Add a howto and some reference documentation.
Rationale
We have an initial deployment in production and need some documentation.
Checklist
src-docs
.urgent
,trivial
,complex
).