Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: network optimization #29

Merged
merged 22 commits into from
Sep 24, 2024
Merged

fix: network optimization #29

merged 22 commits into from
Sep 24, 2024

Conversation

yanksyoon
Copy link
Collaborator

Applicable spec: N/A

Overview

  • feat: enable network optimization policy
  • fix: change ubuntu home dir ownership

Rationale

Module Changes

Library/Dependency Changes

Checklist

  • The contributing guide was applied
  • The documentation is generated using src-docs
  • The PR is tagged with appropriate label (urgent, trivial, complex)
  • The application version in pyproject.toml is incremented

yanksyoon and others added 11 commits September 10, 2024 13:08
@yanksyoon
hotfix: go modules (#23)
3ba49e2 
* hotfix: go mod tidy

* hotfix: add test

* chore: increment version
@yanksyoon
chore: go mod tidy
dbe40b0
@yanksyoon
chore: increment version
186acb2
@yanksyoon
feat: network congestion algo & fix: ubuntu home dir
26d5eb4
@yanksyoon
feat: external cloud upload (#19)
fb9b999 
* feat: upload-cloud parameter

* add src-docs

* documentation

* fix: use user defined name

* change docs to doc (no charmhub docs)

* chore: refactor builder run

* test: increase retry

* remove deprecated reference to chroot builder

* docs: update docs

* swap download function

* fix: enable stream download

* fix: package form

* chore: add server log output

* fix typo

* docs update
@yanksyoon
feat: use external arch param (#21)
a300e6a 
* use external arch param

* bump rev
@yanksyoon
fix: parsable image output (#22)
552c090 
* fix: suppress stdout

* increment patch version

* run go mod tidy

* fix lint

* feat: add parsable output
@yanksyoon
fix: cloud init (#25)
901a31c 
* fix: cloud init script race condition problems

* test: fixup tests

* chore: increment version
@yanksyoon
feat: multicloud upload (#27)
3a64cfa 
* feat: multicloud upload

* chore: increment version

* test: add multiple clouds case

* fix: rename var

* fix: image None

* chore: remove debug
@yanksyoon
fix: sync disk before snapshot (#28)
2a2dcff 
* fix: sync disk before snapshot

* chore: bump rev

* test: fixup tests
@yanksyoon
test: fixup tests
7e9a260
jdkandersson
jdkandersson previously approved these changes Sep 24, 2024
View reviewed changes
src/github_runner_image_builder/builder.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Test coverage for 516be06

Name                                                   Stmts   Miss Branch BrPart  Cover   Missing
--------------------------------------------------------------------------------------------------
src/github_runner_image_builder/__init__.py                0      0      0      0   100%
src/github_runner_image_builder/builder.py               323      0     40      0   100%
src/github_runner_image_builder/chroot.py                 40      0      4      0   100%
src/github_runner_image_builder/cli.py                    46      0      4      0   100%
src/github_runner_image_builder/cloud_image.py            63      0     18      0   100%
src/github_runner_image_builder/config.py                 55      0     18      0   100%
src/github_runner_image_builder/errors.py                 30      0      0      0   100%
src/github_runner_image_builder/logging.py                12      0      0      0   100%
src/github_runner_image_builder/openstack_builder.py     210      0     64      0   100%
src/github_runner_image_builder/store.py                  60      0     16      0   100%
src/github_runner_image_builder/utils.py                  31      0      8      0   100%
--------------------------------------------------------------------------------------------------
TOTAL                                                    870      0    172      0   100%

Static code analysis report

Run started:2024-09-24 08:58:31.383472

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 5463
  Total lines skipped (#nosec): 2
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 51

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@yanksyoon yanksyoon merged commit e14de95 into main Sep 24, 2024
13 checks passed
cbartz
cbartz approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments

src/github_runner_image_builder/builder.py Show resolved Hide resolved
src/github_runner_image_builder/builder.py
"""
try:
subprocess.check_call(
["/usr/bin/chown", "--recursive", "ubuntu:ubuntu", "/home/ubuntu"], # nosec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a constant here for the user?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do it on the next PR! Thanks :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbartz cbartz cbartz approved these changes

@javierdelapuente javierdelapuente javierdelapuente approved these changes

@jdkandersson jdkandersson jdkandersson approved these changes

Assignees
No one assigned
Labels
trivial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanksyoon @javierdelapuente @cbartz @jdkandersson