Fix test runner constructors order and _FORTIFY_SOURCE failure
#729
+63
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the order is undefined, test arrays can be zeroed after initialization.
Pass pointer to the buffer instead of a subarray which is too small for the whole string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with clang (18.1.8 on x86_64-linux-gnu) and
_FORTIFY_SOURCE=2(or 3), I noticed that only half of theunit-testtests were run, which didn't happen with_FORTIFY_SOURCE=0. It turns out that fortifiedmemsetand_##S##_initwere not optimized out, as in the case of_FORTIFY_SOURCE=0, and due to undefined order of constructors, arrays were zeroed after tests were added to them. The first commit sets the order of all functions with__attribute__((constructor)).After fixing the first issue,
tuple/decoder/type/iso8601failed becausestrcpywas passed a pointer to a subarray of size 8 instead of the whole buffer. The second commit fixes this.