-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] End-to-End Tests Refactoring #183
Conversation
Should we make the test repository be in the canonical org? |
It would be great if we can include some documentation on how to execute the new e2e tests and what the new branching strategy is (e.g., merge to |
Yes. Let's address the PR and I will then create a brand new repository (I don't think the history we have there is very relevant) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor nitpicks, please feel free to resolve the conversations to merge!
Co-authored-by: Yanks Yoon <[email protected]>
9a287c6
Co-authored-by: Yanks Yoon <[email protected]>
Test coverage for 187d047
Static code analysis report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
In this PR, we remove the End-2-End tests from the current repository, and moved them to a Test repository, here. The reason for this was:
The idea discussed with @jdkandersson was to export the E2E tests into a separate repository. Of course this exposes us to the risk of merging features that are not working (altough pass unit and integration tests). The idea here would be to have edge and stable branches in this repository. Scheduled E2E tests workflow run against an edge branch in this repository, whereas actions in production should use stable branches. Promoting edge to stable should be a manual process done once we are comfortable a certain revision is good enough.
Tasks
I have now migrated most of the relevant code and business logic about end-to-end testing in the test repository, and I have also extended them to include raising PR and a conflict workflow (only hard conflict so far since the soft ones may go deprecated). This refactoring has however had impacts on this repository as
There is a PR which shows some meaningful diff, on how that was achieved, alongside the tests workflow (against the branch of this PR), here and here. The code in the PR can have several improvements, but I believe it would be more critical to get the end-to-end tests up and running.