allow DBus data type='aay' #368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test-aay.dart actually creates an Avahi service for NearbyShare advertising. If successful, your machine shows up as a Nearby Share device. I notice that canonical Avahis is a very limited implementation via dbus. This test would work nicely there if that package used this new DBus with aay. * test-array-of-arrays.dart is just a rudimentary regression. This is ready for a pull request as I would like to get eyes on as soon as possible. If it gains any traction I will fork the avahi project and add examples from here.
…not versed on dbus byte ordering so am hoping for some eyes on help
|
Hey! crussell42 has not signed the Canonical CLA which is required to get this contribution merged on this project.
Please head over to https://ubuntu.com/legal/contributors to read more about it. |
| @@ -3,3 +3,4 @@ | |||
| pubspec.lock | |||
| test/.test_cov.dart | |||
| coverage/ | |||
| /test/widget_test.dart | |||
There was a problem hiding this comment.
Doesn't seem to be used.
There was a problem hiding this comment.
This was me trying to learn AndroidStudio (click this, click that, suddenly files show up) to run the tests.
|
I left a comment in the issue, basically this was a mistake on my part and I humbly withdraw this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow use of dbus data type='aay' or 'aas' or 'aai' etc.
The idea is
DBusArra(DBusSignature('a'),DBusArray.byte([42,42,42]).This is needed in order to use Avahi daemon (via dbus) on linux to register a Service in an EntryGroup.
The included test-aay.dart does this by creating an NearbyShare advertisment service.
Upon successfully adding the service any NearbyShare on android or Mac or Win box will see our service advertisment.
The structure of the service is pulled from the mac NearDrop repo.
The full intent is to use dbus/avahi as the advertising mechanism in a NearbyShare server on Linux.