fix: replaced ffi getuid by posix package #360
Conversation
|
Hey! aadarshadhakalg has not signed the Canonical CLA which is required to get this contribution merged on this project.
Please head over to https://ubuntu.com/legal/contributors to read more about it. |
|
The posix package wasn't as established at the time but it seems to be now. How does this handle when running on Windows? @jpnurmi any problems doing this you know of? |
|
It seems like the posix package doesnot have windows getsid() implementation, so for windows it still uses existing ffi implementation. |
|
There's also "our own" stdlibc but it doesn't support Windows either. Anyway, is it worth adding any library dependency for that one function? Using |
|
If we can add windows implementation to stdlibc then using stdlibc would be a nice. If we can't do that and we must use ffi to support windows, then adding an extra dependency is not good and we can close this issue I guess. |
|
I'm going to agree here with @jpnurmi - the cost of the dependency doesn't exceeds any benefit of removing the code. Let's stick with what we have. |
Fixes: #191
Use posix package to get uid