bumped minimum Dart SDK constraint to 2.17 #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! MaikuB has not signed the Canonical CLA which is required to get this contribution merged on this project.
Please head over to https://ubuntu.com/legal/contributors to read more about it. |
|
Signed |
|
@robert-ancell I can't seem to assign a reviewer and from what I know, you're the main person working on this so wanted to tag you to bring awareness in case this gets missed :) |
|
Analyze issue fixed in #357 |
|
Thanks @MaikuB! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.7.4 declares that it depends
xml6.1.0+, which requires a minimum Dart SDK version of 2.17 butdbusstill says the minimum it needs is 2.15. This PR is to address this so that it properly declares the minimum supported Dart SDKTwo things that came to mind when I noticed this though
dbusshould've published 0.7.4 as 0.8.0dart:stable. I suspect this could lead to a version drift of the sorts and the repository may need some way to check that the package still supports the minimum Dart SDK version that it advertises