Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weekly workflow to build and publish snap #61

Merged
merged 33 commits into from
Jun 7, 2024
Merged

Weekly workflow to build and publish snap #61

merged 33 commits into from
Jun 7, 2024

Conversation

jpm-canonical
Copy link
Contributor

@jpm-canonical jpm-canonical commented Jun 6, 2024 •
edited
Loading

  • Add the upstream tag or commit hash from connectedhomeip into the snap version.
  • Weekly triggered workflow: If build and test passed, and it's on the main branch, publish amd64 and arm64 snaps to store.

@jpm-canonical
Merge remote-tracking branch 'origin/main' into feature/IENG-1057-git…
3c6ba00 
…hub-workflow
@jpm-canonical
Add publish snap
f0a8176 
Comment out test and arm64 for now
@jpm-canonical
Debug asset file name
f27d690
@jpm-canonical
Remove dependency on other jobs
f64e66a
@jpm-canonical
Add build back
b7c76cf
@jpm-canonical
Add back dependency
0757036
@jpm-canonical
Hardcoded artifact name
9f00fc1
@jpm-canonical
Try upload to store with wildcard name
1563b09
@jpm-canonical
Build and upload with wildcard
74f8296
@jpm-canonical
Do a fake build to speed up
8153baf 
Do an ls to get real artifact file name
@jpm-canonical
Use output variable from build step
39a7652
@jpm-canonical
Write variable to outputs file
5b11e9d
@jpm-canonical
Correct use of variable
00d37b0
@jpm-canonical
Use git hash in snap version
2bd20e7
@jpm-canonical
Re-enable real build
a577164
@jpm-canonical
Check file before upload
6720055
@jpm-canonical
Update snap publish action to use env var for secret
3a543ac
@jpm-canonical
Clean up workflow
0989a8c
@jpm-canonical
Snap version use upstream tag
201aed2 
or fall back to commit hash
@jpm-canonical
Remove arm64 for now to test
45cd3cd
@jpm-canonical
Update version logic
f67c831
@jpm-canonical
Rework snap version
1df7696
@jpm-canonical
Run workflow on self-hosted and enable arm64
f792666
@jpm-canonical
Fix git version command
e687361
@jpm-canonical
Move back to github hosted runners
65cb1c8
@jpm-canonical
Add missing outputs for arm64 build
e000e94
@jpm-canonical
Fix arm64 output variable path
0f5191c
@jpm-canonical
Get snap name from variable in test
feb762b
@jpm-canonical
Remove .snap from zip archive names
ab928b7 
Rename archive name variables
@jpm-canonical
Rename arm64 build step to snapcraft
d6a3e13
@farshidtz farshidtz mentioned this pull request Jun 6, 2024
Closed
farshidtz
farshidtz requested changes Jun 6, 2024
View reviewed changes
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good, but there are some minor issues. Please see the inline comments.

.github/workflows/build-and-test-snap.yml Outdated Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
snap/snapcraft.yaml Outdated Show resolved Hide resolved
@jpm-canonical jpm-canonical requested a review from farshidtz June 7, 2024 09:47
farshidtz
farshidtz approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@farshidtz farshidtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Thanks for the new CI steps and versioning improvements.

Please set an appropriate PR title.

@jpm-canonical jpm-canonical changed the title Feature/ieng 1057 GitHub workflow [IENG-1057] Add weekly build and publish workflow Jun 7, 2024
@jpm-canonical jpm-canonical changed the title [IENG-1057] Add weekly build and publish workflow Weekly workflow to build and publish snap Jun 7, 2024
@jpm-canonical jpm-canonical merged commit a3550bd into main Jun 7, 2024
6 checks passed
@jpm-canonical jpm-canonical deleted the feature/IENG-1057-github-workflow branch June 7, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farshidtz farshidtz farshidtz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpm-canonical @farshidtz