Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-3514] Add Apache Kyuubi entrypoint to Charmed Spark base rock image #75

Merged
merged 7 commits into from
Mar 13, 2024
Merged

[DPE-3514] Add Apache Kyuubi entrypoint to Charmed Spark base rock image #75

merged 7 commits into from
Mar 13, 2024

Conversation

theoctober19th
Copy link
Member

@theoctober19th theoctober19th commented Feb 27, 2024 •
edited
Loading

This PR adds Apache Kyuubi entrypoint to the base image of Charmed Spark.
Jira:
https://warthogs.atlassian.net/browse/DPE-3514

@theoctober19th theoctober19th marked this pull request as ready for review March 8, 2024 04:57
welpaolo
welpaolo previously approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@welpaolo welpaolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

deusebio
deusebio previously approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small non-blocking comment. All good otherwise. Please only add the ticket number in the PR description

rockcraft.yaml Outdated Show resolved Hide resolved
@theoctober19th theoctober19th changed the title Add Apache Kyuubi entrypoint to Charmed Spark base rock image [DPE-3514] Add Apache Kyuubi entrypoint to Charmed Spark base rock image Mar 12, 2024
@theoctober19th theoctober19th dismissed stale reviews from deusebio and welpaolo via f1e514b March 12, 2024 17:13
welpaolo
welpaolo approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@welpaolo welpaolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@theoctober19th theoctober19th merged commit 97487d3 into canonical:3.4-22.04/edge Mar 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welpaolo welpaolo welpaolo approved these changes

@deusebio deusebio deusebio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theoctober19th @welpaolo @deusebio