Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-3344] Charmed Spark <> KubeFlow integration #68

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

deusebio
Copy link
Contributor

No description provided.

@deusebio deusebio changed the title Wip 3344 kf integration [DPE-3344] Charmed Spark <> KubeFlow integration Jan 31, 2024
rockcraft.yaml Outdated Show resolved Hide resolved
@deusebio deusebio changed the base branch from 3.4-22.04/edge to dpe-3104-jupyterlab-image February 1, 2024 16:35
Copy link
Collaborator

@welpaolo welpaolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I left a couple of questions/comments

.github/workflows/publish.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
rockcraft.yaml Outdated Show resolved Hide resolved
Copy link
Member

@theoctober19th theoctober19th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

TODO: Release spark8t and pin the new version in rockcraft.yaml.

tests/integration/integration-tests.sh Show resolved Hide resolved
build/Dockerfile.jupyter Show resolved Hide resolved
Copy link
Collaborator

@welpaolo welpaolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

rockcraft.yaml Show resolved Hide resolved
@deusebio deusebio merged commit 0a9bc66 into dpe-3104-jupyterlab-image Feb 5, 2024
7 checks passed
@deusebio deusebio deleted the wip-3344-kf-integration branch February 5, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants