Update scipy image and requirements for Charmed Kubeflow 1.9 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orfeas-k
reviewed
Jul 16, 2024
There was a problem hiding this comment.
The changes look good. Regarding e2e-wine, we can keep the changes although it's not expected to run in a fresh 1.9 deployment #85.
Trying to run them in 1.9 deployment, it looks like
- kserve fails with the following logs https://pastebin.canonical.com/p/YtVx3cVxKH/
- katib fails with https://pastebin.canonical.com/p/25bYFTXXRB/
That katib failure could be related to canonical/katib-operators#211 although the logs provided there are different but I think the kserve is related to the changes in the PR. Could you take a look at the Kserve one for start?
|
Regarding Katib, LGTM. It is indeed unrelated to this PR. Regarding Kserve, it indeed fails and I captured those logs when running with the driver https://pastebin.canonical.com/p/3Yh2VW4hts/. |
orfeas-k
reviewed
Jul 24, 2024
orfeas-k
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73.
This PR updates the scipy image and the dependencies for all UATs in order to be compatible with CKF 1.9.
kubeflownotebookswg/jupyter-scipy:v1.9.0kubeflow-traininghas been pinned to version1.6.0because of a breaking change in imports, as documented in Update UATs notebooks for neverkubeflow-trainingSDK #84