Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite e2e test #104

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Rewrite e2e test #104

merged 5 commits into from
Aug 23, 2024

Conversation

misohu
Copy link
Member

@misohu misohu commented Aug 19, 2024

Changes:

  • Use mlflow 2.15.1
  • Use kserver 0.13.1
  • Use kfp v2.5.0
  • Use new syntax from kfp v2
  • Replace seldon with kserve

Prerequisites:

UAT test (this can take very long):

  • From the juju machine make sure yuou have kubectl set.
  • Download uats repo and switch to this branch.
  • Instal python3.8 (instructions in uats readme).
  • run tox -e testenv:uats-local (this will run all uats also with e2e wine).
test_notebooks.py::test_notebook[e2e-wine-kfp-mlflow-kserve] 
-------------------------------- live log call ---------------------------------
INFO     test_notebooks:test_notebooks.py:44 Running e2e-wine-kfp-mlflow-kserve.ipynb...
PASSED                                                                   [ 11%]
test_notebooks.py::test_notebook[katib-integration] 
-------------------------------- live log call ---------------------------------
INFO     test_notebooks:test_notebooks.py:44 Running katib-integration.ipynb...
PASSED                                                                   [ 22%]
test_notebooks.py::test_notebook[kfp-v1-integration] 
-------------------------------- live log call ---------------------------------
INFO     test_notebooks:test_notebooks.py:44 Running kfp-v1-integration.ipynb...
PASSED                                                                   [ 33%]
test_notebooks.py::test_notebook[kfp-v2-integration] 
-------------------------------- live log call ---------------------------------
INFO     test_notebooks:test_notebooks.py:44 Running kfp-v2-integration.ipynb...
PASSED                                                                   [ 44%]
test_notebooks.py::test_notebook[kserve-integration] 
-------------------------------- live log call ---------------------------------
INFO     test_notebooks:test_notebooks.py:44 Running kserve-integration.ipynb...
PASSED                                                                   [ 55%]
test_notebooks.py::test_notebook[mlflow-integration] 
-------------------------------- live log call ---------------------------------
INFO     test_notebooks:test_notebooks.py:44 Running mlflow-integration.ipynb...
PASSED                                                                   [ 66%]
test_notebooks.py::test_notebook[mlflow-kserve] 
-------------------------------- live log call ---------------------------------
INFO     test_notebooks:test_notebooks.py:44 Running mlflow-kserve.ipynb...
PASSED                                                                   [ 77%]
test_notebooks.py::test_notebook[mlflow-minio-integration] 
-------------------------------- live log call ---------------------------------
INFO     test_notebooks:test_notebooks.py:44 Running mlflow-minio-integration.ipynb...
PASSED                                                                   [ 88%]
test_notebooks.py::test_notebook[training-integration] 
-------------------------------- live log call ---------------------------------
INFO     test_notebooks:test_notebooks.py:44 Running training-integration.ipynb...
PASSED                                                                   [100%]

Manual test

  • Create jupyter notebook (make sure to add mlflow config from deopdown)
  • Clone UAts in the notebook
  • go to tests/notebooks/e2e-wine
  • Run the notebook cell by cell

image

@misohu misohu marked this pull request as draft August 19, 2024 09:38
@misohu misohu requested a review from a team August 19, 2024 12:19
@misohu misohu marked this pull request as ready for review August 19, 2024 12:19
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @misohu, good job on refactoring the whole thing! left a few comments

@misohu misohu merged commit 75c7c76 into main Aug 23, 2024
1 check passed
@misohu misohu deleted the KF-5995-e2e-test-rewrite branch August 23, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants