fix: remove trailing slash to allow deparam with urls that end with a slash #259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm working with a team to perform static site generation that works with
can-route
, and currently,can-route
'scanRoute_deparam
method doesn't handle urls that end with a trailing slash (/
) properly. This has become problematic when trying to useexpress
to act as a local static server during development.This PR updates
canRoute_deparam
to removing trailing slash (/
) from url when trying todeparam
for path variables.Recreate Steps
This allows for urls like: "progressive-loading/moo" which
deparam
s to:When the url is: "progressive-loading/moo/" (has trailing slash
/
),deparam
s to empty object:When removing the trailing slash (
/
) then attempting todeparam
works as expected.Reason to support urls with trailing slash (
/
)When serving static pages using
express
, following their basic static server example looks something like this:"/static_files/":