-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add observable class field support #32
Conversation
doc/can-define-object.md
Outdated
@@ -96,6 +96,27 @@ myInstance.prop = "NEW VALUE"; | |||
``` | |||
@codepen | |||
|
|||
#### Observable class fields | |||
|
|||
`ObservableObject` [class fields](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Class_fields) are observables like [can-observable-object/object.static.props static props]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be good:
ObservableObject class fields are also observable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phillipskevin The docs are updated, can you review one more time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @cherifGsoul!
For example:
For canjs/can-observable-mixin#79