-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codepen documentation update #375
Merged
Merged
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
94fdd02
propDef examples codepen ready and linked if able
indifferentghost a85af69
codepen-able example in defaultConstructor
indifferentghost c15d339
added default codepen
indifferentghost 672b159
Made most examples codepenable for get
indifferentghost f8bbee3
Merge branch 'master' of https://github.com/canjs/can-define into 362…
indifferentghost 781db4a
added log for propDefinition function type
indifferentghost f678a69
fixed spelling error
indifferentghost 2626333
Added working codepen examples to set.
indifferentghost 99b4a35
linking DefineMap and DefineList to Use in type
indifferentghost 753b914
Removed legacy code from types.get
indifferentghost 9c907d5
updated text to reference can-simple-observable instead of can-comput…
indifferentghost 1dd11b3
changed to updating to latest practises on an example
indifferentghost 73cc278
Changed constructor to shorthand, return from map.
indifferentghost ae37c1a
reverted some changes in 73cc278.
indifferentghost d31a123
fullNameChangeCount example in use section now working and linked to …
indifferentghost File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
locations: DefineList
is short-hand forlocations: { Type: DefineList }
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If It's set like that
this.locations
is undefined in the locationIds getter function.https://codepen.io/anon/pen/XPmmmZ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new keyword was needed in front of
DefaultList
. Fixed in 73cc278.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need the
new
keyword withDefault
. The problem is just that this example doesn't work. I think your original change tolocations: { Default: DefineList }
is the correct way to do this. That is how you do what the description saysSorry to have led you down the wrong path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted these changes made in 73cc278 in ae37c1a.