added Object.defineProperty to connect.js:73, fixed this context in l…

…ocalstorage-cache.js:405
canjs · Jul 3, 2018 · 8d8cda2 · 8d8cda2
1 parent c6939d3
commit 8d8cda2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/connect.js b/connect.js
@@ -70,7 +70,9 @@ connect.behavior = function(name, behavior){
 	var behaviorMixin = function(base){
 		// basically Object.create
 		var Behavior = function(){};
-		Behavior.name = name;
+		Object.defineProperty(Behavior, "name", {
+			value: name
+		});
 		Behavior.prototype = base;
 		var newBehavior = new Behavior();
 		// allows behaviors to be a simple object, not always a function

diff --git a/data/localstorage-cache/localstorage-cache.js b/data/localstorage-cache/localstorage-cache.js
@@ -402,7 +402,7 @@ module.exports = connect.behavior("data/localstorage-cache",function(baseConnect
 					// Get the data for the old set we can union with.
 					return this.getListData(setDatum.set).then(function(setData){
 						// update the old set to the new set
-						self.updateSet(setDatum, canSet.getUnion(setDatum.set, set, getItems(setData), items, this.algebra), union);
+						self.updateSet(setDatum, canSet.getUnion(setDatum.set, set, getItems(setData), items, self.algebra), union);
 					});
 				}
 			}

diff --git a/data/localstorage-cache/localstorage-cache_test.js b/data/localstorage-cache/localstorage-cache_test.js
@@ -332,6 +332,7 @@ QUnit.asyncTest("pagination loses the bigger set (#126)", function(){
 			QUnit.start();
 		});
 	}).catch(function(e){
+		console.log(e);
 		QUnit.ok(false, "something broke");
 		QUnit.start();
 	});