Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve fixed decimals #574

Merged
merged 20 commits into from
Aug 1, 2023
Merged

Improve fixed decimals #574

merged 20 commits into from
Aug 1, 2023

Conversation

skyz1
Copy link
Collaborator

@skyz1 skyz1 commented Jul 15, 2023

This PR improves fixed decimals by storing them as tags and supporting different precission levels.

Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@jwbot jwbot enabled auto-merge July 15, 2023 18:03
@jwbot jwbot added P: Core Package: Candy's standard library P: Builtins Package exposing Candy's compiler builtins labels Jul 15, 2023
@skyz1 skyz1 requested a review from JonasWanke July 15, 2023 18:04
@skyz1 skyz1 marked this pull request as draft July 17, 2023 13:56
auto-merge was automatically disabled July 17, 2023 13:56

Pull request was converted to draft

@skyz1 skyz1 marked this pull request as ready for review July 17, 2023 15:41
@jwbot jwbot added the P: Compiler: VM Package: The VM executing Candy byte code (LIR) label Jul 17, 2023
JonasWanke
JonasWanke requested changes Aug 1, 2023
View reviewed changes
Copy link
Member

@JonasWanke JonasWanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay!

compiler/vm/src/heap/object_inline/int.rs Outdated Show resolved Hide resolved
packages/Core/fixedDecimal.candy Outdated Show resolved Hide resolved
packages/Core/fixedDecimal.candy Outdated Show resolved Hide resolved
packages/Core/fixedDecimal.candy Outdated Show resolved Hide resolved
packages/Core/fixedDecimal.candy Outdated Show resolved Hide resolved
packages/Core/fixedDecimal.candy Outdated Show resolved Hide resolved
packages/Core/fixedDecimal.candy Outdated Show resolved Hide resolved
packages/Core/int.candy Outdated Show resolved Hide resolved
packages/examples/sqrt.candy Outdated Show resolved Hide resolved
skyz1 and others added 5 commits August 1, 2023 15:54
@skyz1 @JonasWanke
fix formatting
e3da5ec 
Co-authored-by: Jonas Wanke <[email protected]>
@skyz1 @JonasWanke
use pipe
52ced82 
Co-authored-by: Jonas Wanke <[email protected]>
@skyz1
refactor is function
9a75e62
@skyz1 @JonasWanke
refactor multiply
f4507ad 
Co-authored-by: Jonas Wanke <[email protected]>
@skyz1 @JonasWanke
refactor int.pow
bfdab5a 
Co-authored-by: Jonas Wanke <[email protected]>
@skyz1 skyz1 requested a review from JonasWanke August 1, 2023 14:10
@JonasWanke JonasWanke merged commit ab531dd into main Aug 1, 2023
10 checks passed
@JonasWanke JonasWanke deleted the improve-fixed-decimal branch August 1, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasWanke JonasWanke JonasWanke approved these changes

Assignees

@skyz1 skyz1

Labels
P: Builtins Package exposing Candy's compiler builtins P: Compiler: VM Package: The VM executing Candy byte code (LIR) P: Core Package: Candy's standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skyz1 @JonasWanke @jwbot