Update Cache to Nitro #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtokman
requested review from
liambutler-lawrence and
nikwotton
as code owners
| @@ -0,0 +1,130 @@ | |||
| # Contributing | |||
| @@ -0,0 +1,20 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) 2024 Gary Tokman | |||
There was a problem hiding this comment.
Suggested change
| Copyright (c) 2024 Gary Tokman | |
| Copyright (c) 2024 Candle Finance Inc. |
We should update all of these if I didn't catch that yesterday
| ruby ">= 2.6.10" | ||
|
|
||
| # Exclude problematic versions of cocoapods and activesupport that causes build failures. | ||
| gem 'cocoapods', '>= 1.13', '!= 1.15.0', '!= 1.15.1' |
| @@ -0,0 +1,3 @@ | |||
| // | |||
| @@ -0,0 +1,31 @@ | |||
| #import "AppDelegate.h" | |||
There was a problem hiding this comment.
Does this need to be in ObjC?
| @@ -0,0 +1,10 @@ | |||
| #import <UIKit/UIKit.h> | |||
There was a problem hiding this comment.
Likewise, does this need to be in ObjC? Why not use Swift for the example app?
| @@ -0,0 +1,66 @@ | |||
| #import <UIKit/UIKit.h> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.