Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

couple of fixes to variantcaller to prevent undeclared values from be… #104

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

couple of fixes to variantcaller to prevent undeclared values from be… #104

wants to merge 1 commit into from

Conversation

rulixxx
Copy link
Collaborator

@rulixxx rulixxx commented Oct 29, 2024

…ing used

fa8sanger
fa8sanger approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@fa8sanger fa8sanger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Some of these changes had been requested in the past but were lost, so this is very welcome. Thank you, Raul

fa8sanger
fa8sanger approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@fa8sanger fa8sanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, thank you Raúl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fa8sanger fa8sanger fa8sanger approved these changes

@ThomasSClarke ThomasSClarke Awaiting requested review from ThomasSClarke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rulixxx @fa8sanger