-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
caveman estep 1.12.0 #77
Comments
zlib >= 1.2.3.5 should be sufficient given the functionality used. |
Hi David
I got my C coder to fix the issue in zlib I believe. There is a limit to the chunck size the utility can use. We have revised the code to write out in smaller chunks and that works ok so far. I am just waiting on the users to qualify the VCF files we have produced.
Will update the forum with the full fix in due course.
Best Rgds
Colin
|
@drjsanger I have the same error for the caveman's step "estep". The error message is: My system is CentOS 7.2 with default gcc coming with that centOS version. The default libz is 1.2.7. Despite version 1.2.7> 1.2.3.5 (the minimum version), caveman raised the error with libz version 1.2.7.
I do not know C programming, but it seems that functions related to libz are not recognized, such as gzprintf, gzopen Questions:
Thanks in advance for your help, |
@ChristopheLegendre I have just tested this using centos7 and it worked for me. Can I ask what reference you're using please? |
@drjsanger |
Thank you @ChristopheLegendre . A quick update: I have tested with a clean install of Centos 7
Using yum installed libraries only:
Which leads to CaVEMan using zlib version 1.2.7
This is failing to reproduce the error when using GRCh37d5 (including all contigs to ensure largest length header possible). It looks from your I'll try that next. Dave |
I can't replicate this error using zlib 1.2.11. I've noticed your GRCh37 has more contigs than ours. I'll try this again using GRCh38 as that has even more contigs to push to limit of the zlib buffer setting and see that is what's causing the problems. Since @OCS-Consult reported that changing the zlib buffer was fixing things I am suspecting a lot of contigs is growing to large for the write buffer. I'd like to reproduce it before I go ahead and make a hotfix though. Still working on it. Dave |
I have now successfully reproduced using a larger number of contigs (GRCh38).
I'll investigate how modifying the buffer size for zlib after file opening can correct this. |
Hi David, Thanks for investigating. |
* Add gzbuffer call after gzopen to ensure we don't hit the limit where many contigs are printed * Added unit test for additional methods * Fixes #77 * Update license dates
I've added a dynamic calculation of contig header section size to ensure the gzbuffer is now set correctly. 1.13.3 contains this fix. @OCS-Consult |
@drjsanger No problems. I am glad I could give some feedback. Best, |
No problem David – you probably hit the issues we fixed with zlib…☺
I’ll let my chaps know.
Rgds
Colin
From: David Jones [mailto:[email protected]]
Sent: 07 September 2018 16:32
To: cancerit/CaVEMan
Cc: Colin Fairbairn; Mention
Subject: Re: [cancerit/CaVEMan] caveman estep 1.12.0 (#77)
I've added a dynamic calculation of contig header section size to ensure the gzbuffer is now set correctly.
13.3.3<https://github.com/cancerit/CaVEMan/releases/tag/1.13.3> contains this fix. @OCS-Consult<https://github.com/OCS-Consult>
apologies this took so long to get fixed!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#77 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AiEfrlIwOuTdSOjNn7vBCEYU0OqJXCuDks5uYpFYgaJpZM4RpW7X>.
…________________________________
DISCLAIMER : This email contains proprietary information some or all of which may be legally privileged. It is for the intended recipient only. If an addressing or transmission error has misdirected this email, please notify the author by replying to this email. If you are not the intended recipient you must not use, disclose, distribute, copy, print or relay on this email. Whilst OCS and its group of companies has taken precautions to avoid the transmission of viruses, it is the responsibility of the recipient to ensure that the onward transmission, opening or use of this message and any attachments will not adversely affect its system or data. No responsibility is accepted by OCS Consulting plc and its group of companies in this regard and the recipient should carry out such virus and other checks as it considers appropriate
Registered Office: 66 Prescot Street, London E1 8NN. United Kingdom Registered No. 1894212 VAT Registration No. 421 3151 09
|
This error has been reported before
[ERROR] (src/output.c: output_vcf_header:302 errno: No such file or directory) Error (0) writing contigs.
[ERROR] (src/estep.c: estep_main:517 errno: None) Error writing header to muts file.
The thread was closed suspecting a zlib error (fixed @ 1.2.8)
However we have the same error and this is on Centos 7 with zlib 1.2.7
$ cat /etc/centos-release
CentOS Linux release 7.4.1708 (Core)
and currently supports zlib:-
[root@server213-171-196-65 /]# rpm -qa zlib*
zlib-1.2.7-17.el7.x86_64
zlib-1.2.7-17.el7.i686
zlib-devel-1.2.7-17.el7.x86_64
As far a I understand there isn't a version of zlib 1.2.8 available for Centos 1.2.7.
Any advice will be appreciated.
The text was updated successfully, but these errors were encountered: