-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lana feedback edits #349
Lana feedback edits #349
Conversation
✅ Deploy Preview for design-system-canada-ca ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
On this page: https://deploy-preview-349--design-system-canada-ca.netlify.app/feedback/when#how-not-to-use-the-feedback-tool There's a "you" in here that should be "your": Use cases for the page feedback tool
|
On this page: https://deploy-preview-349--design-system-canada-ca.netlify.app/feedback/when#how-not-to-use-the-feedback-tool There is an "is" in here that should be an "if": Evaluating page success based on yes / no clicks
|
On this page: https://deploy-preview-349--design-system-canada-ca.netlify.app/feedback/when#how-not-to-use-the-feedback-tool Missing a period at the end of this paragraph: Evaluating statistical significance of feedback based on page visits |
On this page: https://deploy-preview-349--design-system-canada-ca.netlify.app/feedback/about-page-feedback Image description for 2b should remove the "in" After interacting with the “No” button in, a text entry screen will replace the prompt. In the contact option, there is an expand/collapse pattern with the header “Need urgent help with a problem? Contact us”. When the expand/collapse pattern is opened, there is a customizable link to contact the service. After the expand/collapse pattern, there is a heading for “Please provide more details” followed by instructions to not include personal information: “You will not receive a reply. Don’t include personal information (telephone, email, SIN financial, medical, or work details. Maximum 300 characters.” There is a small text entry box followed by a button for “Submit”. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments for some small fixes @LanaStewa
@donohuech Just pushed these edits |
Note: the images aren't displaying because the branch with the new images has not been published.
FN PR: canada-ca/systeme-conception#229
https://deploy-preview-349--design-system-canada-ca.netlify.app/feedback/when
https://deploy-preview-349--design-system-canada-ca.netlify.app/feedback/about-page-feedback
Added images to the how this works page
Added a new on this page section to the "when" page