fix(jackson): replace ObjectMapper with lower-level APIs in FEEL deserializers #1724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the temporary hotfix we had in place to fix the broken FEEL context aware deserialization.
To recap, the issue was that we are calling Jackson deserialization not only on
ObjectMapper
, but also onObjectReader
in case of the polling connector where we need to inject process variables into FEEL expression evaluation. We previously fetched theObjectMapper
instance from the deserialization context, but it turned out that Jackson doesn't necessarily return anObjectMapper
, but actually whatever was used to call the deserialization initially.The proposed solution is to partially switch to lower-level APIs (such as
deserializationContext.readValue(...)
.Java time module
to be preserved in the deserializer.FeelEngineWrapper
for improved type cast support (moved from the deserializer) and readability.Related issues
closes #1552