-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(modules): implement first tests of this repo #30
Conversation
skip-tests:TestUpgradeEKSTestSuite,TestCustomEKSRDSTestSuite
Hello! Quick update from the last time:
The latest CI tests are available at : https://github.com/camunda/camunda-tf-eks-module/actions/runs/8711829425 PS: the renovate config is redundant across repositories, this is something we could consolidate in an single repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the renovate config part but afaik you've created a ticket already 👍 .
Looks good from my side, tests are green! In case of failure a bit more detail is printed to actually debug it.
Renovate we had a look earlier and it captured all the versions 🚀.
For now I think it's fine to capture all renovate updates in a single PR. If we notice it makes sense to split, we can still do so later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you! Just one last comment about the .tool-versions
sorting, but can be merged after that.
Thanks @maxdanilov and @Langleu for the final review, I've removed the autosort of .tool-versions and replaced it by a warning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you! 🚀
Description
This pull request introduces testing for the modules, covering the following scenarios:
The tests are organized into dedicated test suites and can be run in parallel using a separate copy of the module folder. By default, resources are cleaned up at the end of the tests.
Automation:
Please note that tests may take a considerable amount of time and may occasionally fail depending on available AWS resources.
Note: To initiate tests, the pull request must be labeled with "testing-allowed". Otherwise, tests will not be launched and will be marked as failed. Either "testing-allowed" or "testing-ci-not-necessary" labels must be added, the last one allows to skip tests.Known Limitations
Also implement https://github.com/camunda/team-infrastructure-experience/issues/160