Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: examples for terraform doc #166

Merged
merged 147 commits into from
Oct 28, 2024
Merged

feat: examples for terraform doc #166

merged 147 commits into from
Oct 28, 2024

Conversation

leiicamundi
Copy link
Contributor

@leiicamundi leiicamundi commented Oct 11, 2024

This PR adds examples files of our terraform guide for Camunda 8 deployment. Automated tests are not part of this PR.

This PR also introduce a breaking change related to the modules, changing the behavior of the roles from a single role input variable to a list, therefore a v3 will be released after the merge.

Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have overflown it as part of the documentation review. Looks overall good.

I'll do a test run of one path tomorrow and as part of that look at some files in more detail.

@leiicamundi
Copy link
Contributor Author

Thanks for the review @Langleu
If you test the examples, don't forget to replace ref=3.0.0 by this branch.

I have also added a new folder for 8.7 and this PR was tested only for 8.6

@leiicamundi
Copy link
Contributor Author

FYI, I've added a doc regarding the deletion of the EKS Cluster and a new variable to configure the EBS Storage.
I've also updated the config part to let the user providing his s3 bucket.

Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested eksctl + standard last week and terraform + irsa based on the Documentation PR that's related to this.

@leiicamundi
Copy link
Contributor Author

Thank you! Merging this an releasing the 3.0.0 version 🐰

@leiicamundi leiicamundi merged commit f4b64f4 into main Oct 28, 2024
14 checks passed
@leiicamundi leiicamundi deleted the feature/opensearch-doc branch October 28, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants