Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node worker #251

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Fix node worker #251

merged 3 commits into from
Aug 15, 2023

Conversation

vsgoulart
Copy link
Contributor

During her onboarding @esraagamal6 was having difficulties with the zeebe-node worker.

image

This is happening because the script was not working with the existing version of zeebe-node used in the project, so I fixed it. I also used the opportunity to update zeebe-node

I'm not sure who's the DRI for this repo so I just asked for review from the last people active in here

@vsgoulart
Copy link
Contributor Author

I just noticed the Node CI is stuck. I'll check it now

@vsgoulart
Copy link
Contributor Author

Should be ready for review again

@vsgoulart vsgoulart requested a review from jwulf August 14, 2023 12:58
Copy link
Member

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I guess @jwulf would know best.

Copy link
Member

@jwulf jwulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@jwulf jwulf merged commit 18223ab into main Aug 15, 2023
5 checks passed
@jwulf jwulf deleted the fix-node-worker branch August 15, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants