Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: unify workflow names (follow file name) #4657

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

nikku
Copy link
Member

@nikku nikku commented Nov 1, 2024

Proposed Changes

Proposal to make workflow names follow the file names they are defined in.

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

Copy link
Contributor

@misiekhardcore misiekhardcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will cause all those workflow appear with the old and the new name in GH actions section if we do this.

@nikku
Copy link
Member Author

nikku commented Nov 1, 2024

I think this will cause all those workflow appear with the old and the new name in GH actions section if we do this.

I think that would be an OK thing. We'll anyway have some flows decaying, i.e. when we decide to remove them. GitHub added "workflow pinning", so if "focussing on the relevant flows" is something we want to do, then we could use that feature going in the future:

capture dzZNpr_optimized

@nikku nikku merged commit 9fe6fe9 into develop Nov 1, 2024
12 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 1, 2024
@nikku nikku deleted the ci-unify-workflow-names branch November 1, 2024 15:00
@github-actions github-actions bot added this to the M83 milestone Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants