fix(webapps): activityIdIn filter returns all relevant instances #4758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
…ces" This reverts commit e0f66d6.
venetrius
commented
Nov 4, 2024
| @@ -2071,8 +2121,7 @@ public void shouldQueryByActivityIdInWithMultipleScope() { | |||
| assertThat(queryByInnerServiceActivityId.size()).isEqualTo(1); | |||
| assertThat(queryByInnerServiceActivityId.get(0).getId()).isEqualTo(processInstance.getId()); | |||
|
|
|||
| assertThat(queryBySubProcessActivityId.size()).isEqualTo(1); | |||
| assertThat(queryBySubProcessActivityId.get(0).getId()).isEqualTo(processInstance.getId()); | |||
| assertNull(queryBySubProcessActivityId); | |||
There was a problem hiding this comment.
We have 2 instances one at user task innerTask and one in user task outerTask.
Querying by subProcess should return null. The Runtime query has the same behaviur (not returning instances by subProcess activityId)
venetrius
commented
Nov 4, 2024
| @@ -2032,8 +2082,8 @@ public void shouldQueryByActivityIdInWithMultipleScopeAndIncident() { | |||
| assertThat(queryByInnerServiceActivityId.size()).isEqualTo(1); | |||
| assertThat(queryByInnerServiceActivityId.get(0).getId()).isEqualTo(processInstance.getId()); | |||
|
|
|||
| assertThat(queryBySubProcessActivityId.size()).isEqualTo(1); | |||
| assertThat(queryBySubProcessActivityId.get(0).getId()).isEqualTo(processInstance.getId()); | |||
| assertNull(queryBySubProcessActivityId); | |||
There was a problem hiding this comment.
We have 2 instances one at service task innerServiceTask and one in service task outerTask.
Querying by subProcess should return null. The Runtime query has the same behaviour (not returning instances by subProcess activityId)
venetrius
commented
Nov 4, 2024
| @@ -1924,8 +1973,9 @@ public void testHistoricProcInstQueryWithActivityIdsWithFailingActivity() { | |||
|
|
|||
| // then | |||
| assertNotNull(result); | |||
| assertEquals(1, result.size()); | |||
| assertEquals(result.get(0).getId(), failingInstance.getId()); | |||
| assertEquals(2, result.size()); | |||
There was a problem hiding this comment.
Now the instance that has not failed yet as in async waiting returned correctly.
|
Pushed one commit, prev changed passed CI and this should not change behaviour |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: #4757