Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Testing for Router endpoints #3

Open
salaboy opened this issue Sep 4, 2020 · 6 comments
Open

Add Testing for Router endpoints #3

salaboy opened this issue Sep 4, 2020 · 6 comments
Labels
good first issue Good for newcomers hacktoberfest Hacktoberfest 2020 help wanted Extra attention is needed

Comments

@salaboy
Copy link
Collaborator

salaboy commented Sep 4, 2020

Update to Latest version of Spring Zeebe

@salaboy salaboy added good first issue Good for newcomers help wanted Extra attention is needed hacktoberfest Hacktoberfest 2020 labels Sep 4, 2020
@gaurav9822
Copy link

@salaboy can I take this one?

@salaboy
Copy link
Collaborator Author

salaboy commented Oct 4, 2020

@gaurav9822 yes of course.. give it a go and see if you can add some tests to verify that the new client is working.

@gaurav9822
Copy link

@salaboy 0.24.0 is the latest version for "zeebe.version"

@salaboy
Copy link
Collaborator Author

salaboy commented Oct 5, 2020

@gaurav9822 you are right.. 0.25 is coming along but it is still not published.. do you want to start by adding tests? I can rename the issue if you want

@gaurav9822
Copy link

@salaboy I can work on adding tests but can you specify tests for which class/behaviour?

@salaboy salaboy changed the title Update to latest Zeebe Client Add Testing for Router endpoints Oct 13, 2020
@salaboy
Copy link
Collaborator Author

salaboy commented Oct 13, 2020

@gaurav9822 sure..
I would suggest starting with a set of tests for this endpoint:

https://github.com/zeebe-io/zeebe-cloud-events-router/blob/master/src/main/java/io/zeebe/cloud/events/router/ZeebeCloudEventsRouterController.java#L229

Which contains the core functionality of the router.

Then test the Worker code which is here:

https://github.com/zeebe-io/zeebe-cloud-events-router/blob/master/src/main/java/io/zeebe/cloud/events/router/ZeebeCloudEventsRouterWorker.java#L28

If we manage to add these two tests in a single PR that will be awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Hacktoberfest 2020 help wanted Extra attention is needed
Projects
Status: 1️⃣ Good First Issue
Development

No branches or pull requests

2 participants