Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow BPMN message name to be hard coded in Sink connector #20

Open
berndruecker opened this issue Oct 24, 2019 · 3 comments
Open

Allow BPMN message name to be hard coded in Sink connector #20

berndruecker opened this issue Oct 24, 2019 · 3 comments

Comments

@berndruecker
Copy link
Collaborator

In some situation records on one Kafka topic should always sent into Zeebe with the same message name. Currently you have to extract the message name itself from the data of the record.

Current config

    "message.path.messageName": "$.variablesAsMap.messageName",
    "message.path.correlationKey": "$.variablesAsMap.key",
    "message.path.variables": "$.variablesAsMap"

I want to do this

    "message.path.messageName": "messageName",
    "message.path.correlationKey": "$.variablesAsMap.key",
    "message.path.variables": "$.variablesAsMap"

Or maybe we need to rename the attribute into e.g.

    "message.path.messageNameExpression": "$.variablesAsMap.messageName",     
    "message.path.messageName": "messageName",

Which I think is inline to what we do at other places in Zeebe.

And I actually wondered why the attribute is called "message.path" - what's the "path" in it? @npepinpe - probably you know?

@npepinpe
Copy link
Contributor

For JSONPath, but admittedly it probably wasn't necessary to add it there. I think we should focus on migrating to SMT support instead of using JSONPath.

@berndruecker
Copy link
Collaborator Author

I tend to agree (even if this is a quite big refactoring and still will require some thinking around the message name makes total sense to be hardcoded

@npepinpe
Copy link
Contributor

npepinpe commented Dec 6, 2019

I would propose that we allow all values to be hardcoded as well, for example for fan out behaviour you might want the correlation key to be hardcoded to an empty string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants