Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import data models from old importer-script repository #18

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

danduk82
Copy link
Member

@danduk82 danduk82 commented Oct 11, 2024

This PR adds

  • data models for the geoserver types (workspace, datastore, featuretype, etc)
  • a dedicated http client service with dedicated url endpoints for each resource type

Breaking changes
several input parameters of the GeoServerCloud class methods have been renamed:

  • workspace -> workspace_name
  • datastore -> datastore_name

The reason for the breaking change, is that now that we have the types, a workspace is an instance of the geoservercloud.models.Workspace class, and workspace_name is a string that represent the name of the workspace. This applies to all the types.

@danduk82 danduk82 force-pushed the merge_models_from_importer_script branch 7 times, most recently from a369cfd to dcfd39b Compare October 11, 2024 19:39
@danduk82 danduk82 changed the base branch from master to v1.0.x October 14, 2024 10:48
@danduk82 danduk82 force-pushed the merge_models_from_importer_script branch 2 times, most recently from 1567db6 to 54966b8 Compare October 14, 2024 10:52
@danduk82 danduk82 requested a review from vuilleumierc October 14, 2024 10:55
@danduk82 danduk82 marked this pull request as ready for review October 14, 2024 10:55
geoservercloud/models/datastore.py Outdated Show resolved Hide resolved
geoservercloud/models/datastores.py Outdated Show resolved Hide resolved
geoservercloud/models/common.py Outdated Show resolved Hide resolved
geoservercloud/models/workspaces.py Outdated Show resolved Hide resolved
tests/models/test_common.py Outdated Show resolved Hide resolved
tests/test_datastore.py Outdated Show resolved Hide resolved
tests/test_datastore.py Outdated Show resolved Hide resolved
tests/test_datastore.py Outdated Show resolved Hide resolved
tests/test_feature_type.py Show resolved Hide resolved
tests/test_style.py Outdated Show resolved Hide resolved
@danduk82 danduk82 requested a review from vuilleumierc October 14, 2024 19:24
@danduk82 danduk82 changed the base branch from v1.0.x to master October 15, 2024 07:26
@danduk82 danduk82 force-pushed the merge_models_from_importer_script branch from 421ae04 to 1ac85c3 Compare October 15, 2024 07:29
@danduk82 danduk82 merged commit 4d960f6 into master Oct 15, 2024
1 check passed
@danduk82 danduk82 deleted the merge_models_from_importer_script branch October 15, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants