Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove webpack5 workaround #9507

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Remove webpack5 workaround #9507

merged 1 commit into from
Oct 11, 2024

Conversation

ger-benjamin
Copy link
Member

@ger-benjamin ger-benjamin commented Oct 10, 2024

package.json Outdated Show resolved Hide resolved
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the second commit

@ger-benjamin ger-benjamin force-pushed the remove-webpack5-workaround branch from e5a2f16 to 76d71ce Compare October 11, 2024 12:00
@ger-benjamin
Copy link
Member Author

I removed the 1st useless commit.
Now, it's possible that we have more to do in this PR... let's see what the CI say.

@sbrunner
Copy link
Member

Looks to be a wrong reabase!

Using document.currentScript.src is problematic to load ngeo in a
standalone way, with a type="module"
@ger-benjamin ger-benjamin force-pushed the remove-webpack5-workaround branch from 76d71ce to 0e11b30 Compare October 11, 2024 12:04
@ger-benjamin
Copy link
Member Author

Yes, let me one second...

Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :-)

@ger-benjamin ger-benjamin marked this pull request as ready for review October 11, 2024 12:25
@ger-benjamin ger-benjamin merged commit 2c17b03 into master Oct 11, 2024
13 checks passed
@ger-benjamin ger-benjamin deleted the remove-webpack5-workaround branch October 11, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants