Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better peer-dependencies #9504

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

ger-benjamin
Copy link
Member

@ger-benjamin ger-benjamin commented Oct 8, 2024

Change:

  1. Ol moved to as peerDependencies.
  2. I don't see any usage of color-rgba, color-space. They were added to fix sub version, but everything looks working without them. I think we can get ride of them.

Open questions:

  1. We import all d3, we could be more selective. => Tried and was complicated, let see that in another PR
  2. And do we want flexibility on more library ? Candidate:
    1. file-saver
    2. lit*
    3. moment
    4. ol mapbox
    5. ol layerswitcher only used for css !)
    6. qruri
    7. rxjs
    8. tinycolor
    9. Others ?

=> Can be moved to peerDepedencies on demand later.

See JIRA issue: GSNGEO-19.
Examples
Storybook
API help
API documentation

@ger-benjamin ger-benjamin self-assigned this Oct 8, 2024
@ger-benjamin ger-benjamin force-pushed the gsngeo-19-better-peer-dependencies branch from a599406 to 5ee7c7f Compare October 8, 2024 08:36
@ger-benjamin ger-benjamin force-pushed the gsngeo-19-better-peer-dependencies branch from 5ee7c7f to 2193592 Compare October 29, 2024 15:44
@ger-benjamin ger-benjamin requested a review from sbrunner October 29, 2024 15:47
@ger-benjamin ger-benjamin marked this pull request as ready for review October 29, 2024 15:47
@ger-benjamin ger-benjamin force-pushed the gsngeo-19-better-peer-dependencies branch from b66847d to 6c9d097 Compare October 29, 2024 16:58
@ger-benjamin ger-benjamin merged commit 74a3107 into master Oct 29, 2024
13 checks passed
@ger-benjamin ger-benjamin deleted the gsngeo-19-better-peer-dependencies branch October 29, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants