Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't store the user data #9483

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Don't store the user data #9483

merged 1 commit into from
Sep 24, 2024

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Sep 24, 2024

Currently, some runs create a folder like
/tmp/puppeteer_dev_chrome_profile-nXlTSz
with 13Mo of data

See also:
puppeteer/puppeteer#6414

Concretely:

  • Better browser close
  • Set userDataDir to /dev/null

Examples
Storybook
API help
API documentation

@sbrunner sbrunner marked this pull request as ready for review September 24, 2024 06:46
@sbrunner sbrunner force-pushed the puppeteer-temp-files branch 2 times, most recently from 1d168a8 to 6729d81 Compare September 24, 2024 06:54
@sbrunner sbrunner marked this pull request as draft September 24, 2024 07:21
@sbrunner sbrunner force-pushed the puppeteer-temp-files branch 2 times, most recently from 00a7e1c to a93cce7 Compare September 24, 2024 07:44
@sbrunner sbrunner force-pushed the puppeteer-temp-files branch 5 times, most recently from 29c6c6e to ee697c7 Compare September 24, 2024 09:40
Currently, some runs create a folder like
`/tmp/puppeteer_dev_chrome_profile-nXlTSz`
with 13Mo of data

See also:
puppeteer/puppeteer#6414

Concretely:
- Better browser close
- Set `userDataDir` to `/dev/null`
@sbrunner sbrunner force-pushed the puppeteer-temp-files branch from ee697c7 to 8a02ed3 Compare September 24, 2024 10:51
@sbrunner sbrunner marked this pull request as ready for review September 24, 2024 11:39
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where you're using the "incognito" mode

Also, does it affect error stack trace ?

@sbrunner
Copy link
Member Author

Description updated :-)

@sbrunner
Copy link
Member Author

Also, does it affect error stack trace ?

Yes, there are less hiding errors :-)

@sbrunner sbrunner merged commit 043ec1d into master Sep 24, 2024
12 checks passed
@sbrunner sbrunner deleted the puppeteer-temp-files branch September 24, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants