Clean CSS import #9464
Merged
Clean CSS import #9464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ger-benjamin
force-pushed
the
GSNGEO-11-clean-css-import
branch
3 times, most recently
from
041cff7 to
57818da
Compare
ger-benjamin
force-pushed
the
GSNGEO-11-clean-css-import
branch
from
57818da to
3f1227d
Compare
To fix "same specificity weight" problem on examples, I've choosed to apply example scss in priority. Details: - measure (ngeo): won't apply common css first, nonsense. - date-picker (ngeo): Can't easily apply bootstrap css first (as before). - date-picker (gmf): Can't easily apply bootstrap css first (as before). - timeslider (gmf): Can't easily apply bootstrap css first (as before).
ger-benjamin
force-pushed
the
GSNGEO-11-clean-css-import
branch
from
3f1227d to
7133eed
Compare
sbrunner
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Four commits:
For the last point, I discover that: https://github.com/camptocamp/ngeo/compare/GSNGEO-11-clean-css-import?expand=1#diff-1dd2fbbb7774410e5b66e9a554df689ef71981117b2c8fdd6570432cf0a13c59R392
I can imagine an issue with that if we load a external library with css file and another with scss file, targeting the same elements. In this case, the scss one will always have the priority. But in our example... The previous behaviors was weird, that's just problematic that we are "forced" to priorise the scss.
See JIRA issue: GSNGEO-11.
Examples
Storybook
API help
API documentation