Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript-eslint monorepo to v8 (master) (major) #9434

Merged
merged 3 commits into from
Aug 26, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -99,8 +99,8 @@
"@types/sinon": "17.0.3",
"@types/tinycolor2": "1.4.6",
"@types/typeahead": "0.11.32",
"@typescript-eslint/eslint-plugin": "5.62.0",
"@typescript-eslint/parser": "5.62.0",
"@typescript-eslint/eslint-plugin": "8.2.0",
"@typescript-eslint/parser": "8.2.0",
"angular": "1.8.3",
"angular-animate": "1.8.3",
"angular-dynamic-locale": "0.1.38",

Unchanged files with check annotations Beta

cy.wrap(btn)
.click({force: true})
.then((btn) => {
expect(btn).to.not.be.visible;

Check failure on line 467 in src/e2e/mobile.spec.ts

GitHub Actions / Continuous integration

Expected an assignment or function call and instead saw an expression
// Check the placeholder
cy.get('.tt-input').should('have.attr', 'placeholder', 'Search…');
this.processBuffer_(data, iter, distanceOffset, lastLOD, resetPlot);
})
.catch((err: Error) => {
throw `Error on pytree query: ${err.message}`;

Check failure on line 424 in src/lidar/Manager.ts

GitHub Actions / Continuous integration

Expected an error object to be thrown
});
}
try {
JSON.parse(strHeaderLocal);
} catch (e) {

Check failure on line 473 in src/lidar/Manager.ts

GitHub Actions / Continuous integration

'e' is defined but never used
if (!this.isPlotSetup_) {
const canvas: any = d3select(lidarContainerElement.querySelector('.lidar-canvas'));
const canvasEl: HTMLCanvasElement = canvas.node();
* @param key The key string of the toggled classification.
*/
toggleVisibility(classification: LidarprofileServerConfigClassification, key: string): void {
classification.visible === 0 ? (classification.visible = 1) : (classification.visible = 0);

Check failure on line 260 in src/lidar/PanelElement.ts

GitHub Actions / Continuous integration

Expected an assignment or function call and instead saw an expression
this.setClassification(classification, parseInt(key));
}
source.clear();
const lidarPointGeom = new olGeomPoint([p.coords[0], p.coords[1]]);
const lidarPointFeature = new olFeature(lidarPointGeom);
if (typeof pointClassification.color !== undefined) {

Check failure on line 505 in src/lidar/Plot.ts

GitHub Actions / Continuous integration

Invalid typeof comparison value
lidarPointFeature.setStyle(
new olStyleStyle({
image: new olStyleCircle({
const classNames = ['alert', 'fade', 'show'];
switch (type) {
case MessageType.ERROR:

Check failure on line 109 in src/message/Notification.ts

GitHub Actions / Continuous integration

The case statement does not have a shared enum type with the switch predicate
classNames.push('alert-danger');
break;
case MessageType.INFORMATION:

Check failure on line 112 in src/message/Notification.ts

GitHub Actions / Continuous integration

The case statement does not have a shared enum type with the switch predicate
classNames.push('alert-info');
break;
case MessageType.SUCCESS:

Check failure on line 115 in src/message/Notification.ts

GitHub Actions / Continuous integration

The case statement does not have a shared enum type with the switch predicate
classNames.push('alert-success');
break;
case MessageType.WARNING:

Check failure on line 118 in src/message/Notification.ts

GitHub Actions / Continuous integration

The case statement does not have a shared enum type with the switch predicate
classNames.push('alert-warning');
break;
default:
.attr('dy', '.75em')
.attr('transform', 'rotate(-90)')
.style('fill', 'grey')
.text(`${yAxisLabel} [m]`); // eslint-disable-line @typescript-eslint/restrict-template-expressions

Check failure on line 340 in src/profile/d3Elevation.ts

GitHub Actions / Continuous integration

'yAxisLabel' will use Object's default stringification format ('[object Object]') when stringified
gEnter
.append('g')