Lazy load legend images #9393
Merged
Lazy load legend images #9393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load https://carto.grand-chatellerault.fr/theme/ads 20x faster.
There is 793 legend images / 930 requests at loading time => 2min
Legend images are put in queue before tiles, and WMS layers, portal is not usable before 2 min.
With this change it takes 6 sec: https://lamiseretest.grand-chatellerault.fr/theme/ads
I made the PR on 2.8, but IMHO it could be backported on all supported versions.
Note: This comes with the side effect that legend images start loading after expanding the group and appear while receiving images. Not sure we need an option for this.
Examples
Storybook
API help
API documentation