Skip to content

Commit

Permalink
Add regenerate example files mode
Browse files Browse the repository at this point in the history
  • Loading branch information
sbrunner committed Oct 31, 2024
1 parent c3fc9f9 commit 5c92ad0
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 5 deletions.
11 changes: 10 additions & 1 deletion .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:

env:
PATH: /bin:/usr/bin:/usr/local/bin:/home/runner/.local/bin
REGENERATE_EXAMPLES: true

steps:
- name: GitHub event
Expand Down Expand Up @@ -115,7 +116,10 @@ jobs:
NODE_OPTIONS: --openssl-legacy-provider
if: github.event_name != 'pull_request_target'
- run: make check-examples-checker
if: github.event_name != 'pull_request_target'
if: |
github.event_name != 'pull_request_target'
&& env.REGENERATE_EXAMPLES == 'false'
# Cypress tests
- run: make serve-gmf-apps &
if: github.event_name != 'pull_request_target'
Expand All @@ -133,6 +137,11 @@ jobs:
NODE_OPTIONS: --openssl-legacy-provider
- run: make check-examples
if: github.event_name != 'pull_request_target'
- run: |
rm examples/error-ref.png
find . ! -name *-ref.png -type f -exec rm {} \;
if: env.REGENERATE_EXAMPLES == 'true'
- run: '[ ${REGENERATE_EXAMPLES} == false ]'
- uses: actions/upload-artifact@v4
with:
name: Examples
Expand Down
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,8 @@ contribs/dist: .build/build-dll.timestamp
mkdir -p $(dir $@)
CI=true LANGUAGE=en_US buildtools/retry node buildtools/check-example.js \
.build/examples-hosted/error.html
! buildtools/check-example .build/examples-hosted/error.html.png examples/error-ref.png
# Only if REGENERATE_EXAMPLES is not true
! ( [ ${REGENERATE_EXAMPLES} != true ] && buildtools/check-example .build/examples-hosted/error.html.png examples/error-ref.png )
touch $@

# Add --generate as argument to buildtools/check-example to regenerate the reference images
Expand Down
13 changes: 10 additions & 3 deletions buildtools/check-example
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,16 @@ def main():
stdout=subprocess.PIPE,
)
result = float(result.stdout.decode().splitlines()[-1].split()[1])
if result > 0.01:
print(f"{result} > 0.01 => {diff}")
sys.exit(1)
if os.environ.get("REGENERATE_EXAMPLES") == "true":
if result > 0:
shutil.copyfile(current, old_ref)
print(f"::error file={old_ref}:: Regenerate the ref image: {old_ref}")
else:
os.remove(old_ref)
else:
if result > 0.01:
print(f"{result} > 0.01 => {diff}")
sys.exit(1)


if __name__ == "__main__":
Expand Down

0 comments on commit 5c92ad0

Please sign in to comment.