Fix or ignore new checks errors

camptocamp · Aug 26, 2024 · 2e42c53 · 2e42c53
1 parent ce2c3f7
commit 2e42c53
Show file tree

Hide file tree

Showing 12 changed files with 26 additions and 18 deletions.
diff --git a/.eslintrc.yaml b/.eslintrc.yaml
@@ -59,6 +59,11 @@ rules:
   '@typescript-eslint/no-misused-promises': warn
   '@typescript-eslint/require-await': warn
   '@typescript-eslint/no-unsafe-argument': warn
+  '@typescript-eslint/no-unused-vars': warn
+  '@typescript-eslint/no-unused-expressions': warn
+  '@typescript-eslint/prefer-promise-reject-errors': warn
+  # TODO: Remove before release 2.9
+  '@typescript-eslint/no-require-imports': warn
   '@typescript-eslint/no-useless-constructor': error
   '@typescript-eslint/prefer-for-of': error
   '@typescript-eslint/prefer-includes': error

diff --git a/src/e2e/mobile.spec.ts b/src/e2e/mobile.spec.ts
@@ -464,7 +464,7 @@ if (Cypress.browser.isHeaded) {
           cy.wrap(btn)
             .click({force: true})
             .then((btn) => {
-              expect(btn).to.not.be.visible;
+              expect(btn).to.not.be.visible; // eslint-disable-line @typescript-eslint/no-unused-expressions
 
               // Check the placeholder
               cy.get('.tt-input').should('have.attr', 'placeholder', 'Search…');

diff --git a/src/lidar/Manager.ts b/src/lidar/Manager.ts
@@ -421,7 +421,7 @@ export class LidarprofileManager {
         this.processBuffer_(data, iter, distanceOffset, lastLOD, resetPlot);
       })
       .catch((err: Error) => {
-        throw `Error on pytree query: ${err.message}`;
+        throw new Error(`Error on pytree query: ${err.message}`);
       });
   }
 
@@ -470,6 +470,7 @@ export class LidarprofileManager {
 
     try {
       JSON.parse(strHeaderLocal);
+      // eslint-disable-next-line @typescript-eslint/no-unused-vars
     } catch (e) {
       if (!this.isPlotSetup_) {
         const canvas: any = d3select(lidarContainerElement.querySelector('.lidar-canvas'));

diff --git a/src/lidar/PanelElement.ts b/src/lidar/PanelElement.ts
@@ -257,7 +257,7 @@ export default class GmfLidarPanel extends ToolPanelElement {
    * @param key The key string of the toggled classification.
    */
   toggleVisibility(classification: LidarprofileServerConfigClassification, key: string): void {
-    classification.visible === 0 ? (classification.visible = 1) : (classification.visible = 0);
+    classification.visible = classification.visible === 0 ? 1 : 0;
     this.setClassification(classification, parseInt(key));
   }
 

diff --git a/src/lidar/Plot.ts b/src/lidar/Plot.ts
@@ -502,7 +502,7 @@ export default class {
       source.clear();
       const lidarPointGeom = new olGeomPoint([p.coords[0], p.coords[1]]);
       const lidarPointFeature = new olFeature(lidarPointGeom);
-      if (typeof pointClassification.color !== undefined) {
+      if (pointClassification.color !== undefined) {
         lidarPointFeature.setStyle(
           new olStyleStyle({
             image: new olStyleCircle({

diff --git a/src/message/Disclaimer.js b/src/message/Disclaimer.js
@@ -337,7 +337,7 @@ export class MessageDisclaimerService extends ngeoMessageMessage {
         jqueryObj.alert('close');
       }
     } else {
-      console.log(`No disclaimer found for  '${message}'.`);
+      console.log(`No disclaimer found for '${message.msg}'.`);
     }
 
     // (3) Remove message from cache since it's closed now.

diff --git a/src/message/Notification.ts b/src/message/Notification.ts
@@ -106,16 +106,16 @@ export class MessageNotification extends ngeoMessageMessage {
 
     const classNames = ['alert', 'fade', 'show'];
     switch (type) {
-      case MessageType.ERROR:
+      case MessageType.ERROR: // eslint-disable-line @typescript-eslint/no-unsafe-enum-comparison
         classNames.push('alert-danger');
         break;
-      case MessageType.INFORMATION:
+      case MessageType.INFORMATION: // eslint-disable-line @typescript-eslint/no-unsafe-enum-comparison
         classNames.push('alert-info');
         break;
-      case MessageType.SUCCESS:
+      case MessageType.SUCCESS: // eslint-disable-line @typescript-eslint/no-unsafe-enum-comparison
         classNames.push('alert-success');
         break;
-      case MessageType.WARNING:
+      case MessageType.WARNING: // eslint-disable-line @typescript-eslint/no-unsafe-enum-comparison
         classNames.push('alert-warning');
         break;
       default:

diff --git a/src/message/Notification_OLD.js b/src/message/Notification_OLD.js
@@ -109,16 +109,16 @@ export class MessageNotification extends ngeoMessageMessage {
 
     const classNames = ['alert', 'fade', 'show'];
     switch (type) {
-      case MessageType.ERROR:
+      case MessageType.ERROR: // eslint-disable-line @typescript-eslint/no-unsafe-enum-comparison
         classNames.push('alert-danger');
         break;
-      case MessageType.INFORMATION:
+      case MessageType.INFORMATION: // eslint-disable-line @typescript-eslint/no-unsafe-enum-comparison
         classNames.push('alert-info');
         break;
-      case MessageType.SUCCESS:
+      case MessageType.SUCCESS: // eslint-disable-line @typescript-eslint/no-unsafe-enum-comparison
         classNames.push('alert-success');
         break;
-      case MessageType.WARNING:
+      case MessageType.WARNING: // eslint-disable-line @typescript-eslint/no-unsafe-enum-comparison
         classNames.push('alert-warning');
         break;
       default:

diff --git a/src/misc/php-date-formatter.js b/src/misc/php-date-formatter.js
@@ -79,7 +79,7 @@ function _compare(str1, str2) {
  * @returns {string}
  */
 function _lpad(value, length, chr) {
-  const val = value.toString();
+  const val = value.toString(); // eslint-disable-line @typescript-eslint/no-base-to-string
   chr = chr || '0';
   return val.length < length ? _lpad(chr + val, length) : val;
 }

diff --git a/src/profile/d3Elevation.ts b/src/profile/d3Elevation.ts
@@ -337,7 +337,7 @@ function d3Elevation(
           .attr('dy', '.75em')
           .attr('transform', 'rotate(-90)')
           .style('fill', 'grey')
-          .text(`${yAxisLabel} [m]`); // eslint-disable-line @typescript-eslint/restrict-template-expressions
+          .text(`${yAxisLabel} [m]`); // eslint-disable-line @typescript-eslint/restrict-template-expressions,@typescript-eslint/no-base-to-string
 
         gEnter
           .append('g')
@@ -447,7 +447,7 @@ function d3Elevation(
         g.select('.x.axis').transition().call(xAxis);
 
         g.select('.x.label')
-          .text(`${xAxisLabel} [${xUnits}]`) // eslint-disable-line @typescript-eslint/restrict-template-expressions
+          .text(`${xAxisLabel} [${xUnits}]`) // eslint-disable-line @typescript-eslint/restrict-template-expressions,@typescript-eslint/no-base-to-string
           .style('fill', 'grey')
           .style('shape-rendering', 'crispEdges');
 

diff --git a/src/query/Querent.js b/src/query/Querent.js
@@ -265,8 +265,8 @@ export class Querent {
    */
   wfsDescribeFeatureType(dataSource) {
     if (!dataSource.supportsAttributes) {
-      throw `The data source must support WFS, have a single OGCLayer that
-      is queryable in order to issue WFS DescribeFeatureType requests`;
+      throw new Error(`The data source must support WFS, have a single OGCLayer that
+      is queryable in order to issue WFS DescribeFeatureType requests`);
     }
     if (!dataSource.wfsUrl) {
       throw new Error('Missing WFS URL');

diff --git a/webpack.config.js b/webpack.config.js
@@ -19,6 +19,8 @@
 // IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 // CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
+/* eslint-disable @typescript-eslint/no-require-imports */
+
 const {merge} = require('webpack-merge');
 
 module.exports = (env, args) => {