fix(text-expand): remove margin and add padding in ng-content to fix …

…cutoff abstract note: margins should not be used within gn-ui max-lines component since getBoundingClientRect calculating the needed max height does not take them into account
camptocamp · Sep 5, 2024 · 44a20e9 · 44a20e9
1 parent 1ab9d85
commit 44a20e9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/apps/datahub/src/app/dataset/dataset-header/dataset-header.component.html b/apps/datahub/src/app/dataset/dataset-header/dataset-header.component.html
@@ -41,7 +41,7 @@ <h2 class="mel-section-title mb-6" translate>mel.dataset.abstract</h2>
       [showContent]="fieldReady('abstract')"
     >
       <mel-datahub-text-expand [maxLines]="3"
-        ><div class="sm:block text-2xl">
+        ><div class="sm:block text-2xl pb-8">
           <gn-ui-markdown-parser
             [textContent]="record.abstract"
           ></gn-ui-markdown-parser></div

diff --git a/libs/mel/src/lib/text-expand/text-expand.component.html b/libs/mel/src/lib/text-expand/text-expand.component.html
@@ -1,6 +1,6 @@
 <div
   #container
-  class="overflow-hidden transition-[max-height] duration-300 mb-8 relative"
+  class="overflow-hidden transition-[max-height] duration-300 relative"
   [ngClass]="isExpanded || !showToggleButton ? 'ease-in' : 'ease-out'"
   [style.maxHeight]="maxHeight"
 >