Skip to content

Commit

Permalink
Merge pull request #219 from camptocamp/external-docker-schema
Browse files Browse the repository at this point in the history
Add missing entry in the schema for External Secret Docker registries
  • Loading branch information
sbrunner authored Sep 4, 2024
2 parents a654eb9 + 6937023 commit 1d8f87b
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
2 changes: 0 additions & 2 deletions templates/external-secret-docker-registry.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@ spec:
secretStoreRef: {{- toYaml . | nindent 4 }}
{{- end }}
target:
{{- if not ( hasKey ( default ( dict ) .target ) "name" ) }}
name: {{ include "common.fullname" ( dict "root" $ "service" . "serviceName" "external-secret" ) }}
{{- end }}
template:
type: kubernetes.io/dockerconfigjson
data:
Expand Down
2 changes: 2 additions & 0 deletions values.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@
- **`annotations`**: Refer to _[#/definitions/annotations](#definitions/annotations)_.
- **`enabled`** _(boolean)_: Enable the Docker registry.
- **`external`** _(boolean)_: Use an external secret to the Docker registries username, password and email.
- **`refreshInterval`** _(string)_: The refresh interval like 1h, 1m, 1s.
- **`secretStoreRef`** _(object)_: defines which SecretStore to fetch the ExternalSecret data.
- **`content`** _(object)_: Docker registries authentication. Can contain additional properties.
- **Additional properties** _(object)_: Cannot contain additional properties.
- **`username`** _(string)_: Username.
Expand Down
8 changes: 8 additions & 0 deletions values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,14 @@
"type": "boolean",
"description": "Use an external secret to the Docker registries username, password and email"
},
"refreshInterval": {
"type": "string",
"description": "The refresh interval like 1h, 1m, 1s"
},
"secretStoreRef": {
"type": "object",
"description": "defines which SecretStore to fetch the ExternalSecret data."
},
"content": {
"type": "object",
"description": "Docker registries authentication",
Expand Down

0 comments on commit 1d8f87b

Please sign in to comment.