Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't steal pull request #575

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Oct 25, 2024

If a pull request has already a milestone (=> considered to be in another release) don't put it in the new release.

With this, it will work better if e.g. on the master branch we do the releases 1.0.1 then 1.0.1 and 1.1.0

With the latest version, when we do the release 1.1.0 she will steal the pull request of release 1.0.1, it shouldn't be the sase anymore.

@sbrunner sbrunner changed the title Don't stool pull request Don't steal pull request Oct 28, 2024
If a pull request has already a milestone (=> consider as be in an other
release) don't put it in the new release.
@sbrunner sbrunner force-pushed the changelog-dont-stoll-pullrequest branch from 676e249 to 4394c4e Compare October 28, 2024 10:18
@sbrunner sbrunner enabled auto-merge October 28, 2024 10:18
@sbrunner sbrunner merged commit 8c3bc6b into master Oct 28, 2024
6 checks passed
@sbrunner sbrunner deleted the changelog-dont-stoll-pullrequest branch October 28, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant