Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSGGR-156 implement authentication for the frontend-authenticated user #43

Merged
merged 7 commits into from
Oct 1, 2024
Merged

GSGGR-156 implement authentication for the frontend-authenticated user #43

merged 7 commits into from
Oct 1, 2024

Conversation

lanseg
Copy link
Contributor

@lanseg lanseg commented Sep 26, 2024

Flow:

  1. Frontend authenticates in Zitadel, receives an access token and sends it to backend.
  2. Backend uses service key and gets user information from the OIDC provider for given access token.
  3. If key validation fails then return error. If everything is ok, then user is created and updated.
  4. Send a refresh and access tokens to the frontend.

Configuration requires an extra account on the Zitadel side (of a General API type)

@lanseg lanseg self-assigned this Sep 26, 2024
hbollon
hbollon approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@hbollon hbollon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

danduk82
danduk82 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@danduk82 danduk82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me as well, one little comment but lgtm also in the current state

oidc.py Show resolved Hide resolved
@lanseg lanseg merged commit de7df1f into master Oct 1, 2024
1 check passed
@lanseg lanseg deleted the GSGGR-156.2-frontend-auth-backend branch October 1, 2024 11:05
lanseg pushed a commit that referenced this pull request Nov 27, 2024
@danduk82
Merge pull request #43 from camptocamp/GSGGR-187-better-downloads
72e237a 
(feat) GSGGR-187 better downloads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbollon hbollon hbollon approved these changes

@danduk82 danduk82 danduk82 approved these changes

@marionb marionb Awaiting requested review from marionb

@gberaudo gberaudo Awaiting requested review from gberaudo

Assignees

@lanseg lanseg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lanseg @danduk82 @hbollon