Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docker-compose): use remote GHCR images for geoshop apps #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(docker-compose): use remote GHCR images for geoshop apps #21

wants to merge 1 commit into from

Conversation

hbollon
Copy link
Member

@hbollon hbollon commented Sep 16, 2024

The long diff is due to file format (the indentation wasn't consistent)

@hbollon hbollon requested a review from marionb September 16, 2024 11:20
@hbollon hbollon self-assigned this Sep 16, 2024
marionb
marionb reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@marionb marionb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a misunderstanding with the correct FE. Can you correct this then I will just shortly test locally.

docker-compose.yaml Show resolved Hide resolved
docker-compose.yaml Outdated Show resolved Hide resolved
@marionb marionb requested a review from lanseg September 17, 2024 06:37
@marionb
Copy link
Member

marionb commented Sep 17, 2024 •
edited
Loading

FYI: @lanseg this will change the use of the images instead of building them from the Docker files.
And do you know what the FE image is for on line docker-compose.yml on Line 8? Is this the FE for the extract? can you confirm this? will we need to publish an image for this as well?

lanseg
lanseg approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@lanseg lanseg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it, but I'll have to double-check my pull request for GSGGR-164

@hbollon hbollon force-pushed the chore/update-docker-compose-images branch from 2340fe4 to 373a84f Compare September 17, 2024 07:32
@hbollon hbollon requested a review from marionb September 17, 2024 07:34
marionb
marionb approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@marionb marionb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hbollon Currently the composition is not staring but I don't think it is this PR or it is a combination with something existing.
Can you merge it and I will debug this tomorrow morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marionb marionb marionb approved these changes

@lanseg lanseg lanseg approved these changes

Assignees

@hbollon hbollon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbollon @marionb @lanseg