feat(example): devops-stack on scaleway #1271
Conversation
| # INFRA + K8s PHASE | ||
| # ########################### | ||
| module "scaleway" { | ||
| source = "[email protected]:camptocamp/devops-stack-module-cluster-scaleway.git" |
There was a problem hiding this comment.
This here should be versioned to a tag of the repository.
There was a problem hiding this comment.
In my opinion the documentation could be completed with more explanations like in the other examples.
There was a problem hiding this comment.
i can't see any README for the other example. So this one is not too bad.
There was a problem hiding this comment.
Actually there is not supposed to be a README.md but rather a documentation page like those here.
There was a problem hiding this comment.
ok, i added the doc to the devops-stack-module-cluster-scaleway module.
| ``` | ||
|
|
||
| ## Usage | ||
| Get the kubeconfig file and the domain name with the following commands: |
There was a problem hiding this comment.
In my opinion, it's not best practice to use this Kubeconfig file as a way to authenticate to the cluster, since these are the same values used for setting the providers in the Terraform configuration. Maybe there is a way to recover new secret and ephemeral certificates using the Scaleway CLI utility, if it exists (see the SKS example).
examples/scaleway/main.tf
Outdated
| helm_values = [{ | ||
| traefik = { | ||
| service = { | ||
| type = "LoadBalancer" | ||
| annotations = { | ||
| "service.beta.kubernetes.io/scw-loadbalancer-id" = module.cluster.lb_id | ||
| "service.beta.kubernetes.io/scw-loadbalancer-id" = module.scaleway.lb_id | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
If this a required setting for the Traefik module, maybe a new variant of that module should be created. I see that this is very similar to what was done on the SKS module.
Using the helm_values variable should be discouraged and used only for edge cases.
There was a problem hiding this comment.
A few notes on this file:
- multiple modules are not using the latest versions;
- the Thanos module should also be included like in the other examples;
There was a problem hiding this comment.
yes agree, maybe for later version
There was a problem hiding this comment.
Since this is the first version and it's not something that somebody is depending on, why not do it properly the first time around?
Xaving
force-pushed
the
example-scaleway
branch
4 times, most recently
from
58269d7 to
9a2b452
Compare
| examples/*/.terraform | ||
| examples/*/terraform.tfstate | ||
| examples/*/terraform.tfstate.* | ||
| examples/*/.terraform.tfstate.lock.info | ||
| examples/*/*-config | ||
| examples/*/.terraform.lock.hcl | ||
|
|
||
| examples/*/secrets.yml |
There was a problem hiding this comment.
This should no be here, because we add these files with a placeholder content to the examples. See here, for example.
| examples/*/terraform.tfstate* | ||
| examples/*/.terraform.lock.hcl |
There was a problem hiding this comment.
These lines are doubled and already exist in the file.
| examples/*/kubeconfig.yml | ||
| examples/*/issue.txt | ||
| examples/*/log.txt | ||
| examples/*/*.png | ||
| examples/*/*.html | ||
| examples/*/issuers.yml |
There was a problem hiding this comment.
I think only you have this files in your folders. Should we add it to the .gitignore and include these exceptions for everybody?
chore(scaleway): first example
chore(scaleway): first example
Description of the changes
Add an example to start a devops-stack on Scaleway