chore(scaleway-variant): add lb annotation

[Xaving]

Use scaleway annotation for load balancer.

The change only impacts scaleway part.

Breaking change

• No
• Yes (in the Helm chart(s)): indicate the chart, version & release note link
• Yes (in the module itself): give an explanation of the breaking change

Tests executed on which distribution(s)

• KinD
• AKS (Azure)
• EKS (AWS)
• Scaleway
• SKS (Exoscale)

[lentidas]

On the scope of the commit and the title of the PR I would put scaleway instead of scaleway-variant because variant is implied.

[lentidas]

Since you're using a service type of LoadBalancer, on the main.tf you do not need to call the nodeport variant but instead you can call the main module directly. So the source in this line should be ../ instead of ../nodeport.

[lentidas]

For a question of maintaining style with the other modules, the description should come first. I also added a nullable = false because I think this value is required and we cannot risk anybody passing a null value and cause an undefined behavior (that is something I also should have done on the SKS variant and did not do it).

Suggested change

	type = string
	description = "ID of the main load balancer"
	description = "ID of the Scaleway Load Balancer to use for the Kubernetes cluster."
	type = string
	nullable = false