Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a variable that enables/disables network policies #85

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

omohammed95
Copy link
Contributor

@omohammed95 omohammed95 commented May 31, 2024

Description of the changes

This PR introduces a variable to enable or disable network policies for Thanos components. Previously, the network policy values were hard-coded, limiting flexibility and customization. By adding this variable, users can easily configure network policies as per their requirements.

Breaking change

  • No

Tests executed on which distribution(s)

  • AKS (Azure)

@omohammed95 omohammed95 force-pushed the thanos-netpol-variable branch from c9ab498 to ded19b8 Compare June 3, 2024 13:20
@omohammed95 omohammed95 marked this pull request as ready for review July 23, 2024 08:39
@omohammed95 omohammed95 requested a review from a team as a code owner July 23, 2024 08:39
@omohammed95 omohammed95 self-assigned this Jul 26, 2024
@lentidas
Copy link
Contributor

lentidas commented Aug 7, 2024

I do not think that this will be this simple... back from when I tested this, simply enabling the network policies broke the communication between the other modules and the Thanos module. Also, since we deploy a Redis for caching metrics, we will also need to create and deploy customized Network Policies to regulate that network traffic.

And one more thing, I think naming the variable network_policy_thanos is not the best name, since this variable will also exist on other modules. In my opinion, something like enable_network_policies would be more adequate.

@omohammed95 omohammed95 force-pushed the thanos-netpol-variable branch from 19e7b79 to 23647a1 Compare August 20, 2024 15:07
docs(terraform-docs): generate docs and write to README.adoc
@omohammed95 omohammed95 force-pushed the thanos-netpol-variable branch from 87b055d to 5ffc39f Compare August 21, 2024 09:09
@omohammed95 omohammed95 force-pushed the thanos-netpol-variable branch from fe8bce9 to 1152c08 Compare August 21, 2024 11:31
@omohammed95 omohammed95 force-pushed the thanos-netpol-variable branch from c2ea925 to f7bc36b Compare August 21, 2024 11:36
@nbessi nbessi self-requested a review August 21, 2024 12:09
nbessi
nbessi previously approved these changes Aug 22, 2024
nbessi
nbessi previously approved these changes Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants