feat: monitor Thanos components #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modridi
force-pushed
the
monitor-thanos-ISDEVOPS-254
branch
2 times, most recently
from
3495da8 to
19891ee
Compare
lentidas
reviewed
Oct 6, 2023
Comment on lines
+6
to
+25
| metrics = { | ||
| enabled = true | ||
| serviceMonitor = { | ||
| enabled = true | ||
| } | ||
| } |
There was a problem hiding this comment.
Just FYI, this could be problematic. I'm not sure Thanos could be deployed after kube-prometheus-stack (possibly I'm mistaken), which in this case is would be required because of the ServiceMonitor CRD.
modridi
force-pushed
the
monitor-thanos-ISDEVOPS-254
branch
from
2b34984 to
30b4574
Compare
modridi
force-pushed
the
monitor-thanos-ISDEVOPS-254
branch
from
bd76b6c to
ba8f512
Compare
modridi
force-pushed
the
monitor-thanos-ISDEVOPS-254
branch
from
1248cec to
4348e6a
Compare
|
PR closed because is was superseded by #73. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
In this section, explain what and why not how.
In most cases, you can leave out details about how a change has been made. Code is generally self-explanatory in this regard (and if the code is so complex that it needs to be explained in prose, that’s what source comments are for). Just focus on making clear the reasons why you made the change in the first place, the way things worked before the change (and what was wrong with that), the way they work now, and why you decided to solve it the way you did.
Breaking change
Tests executed on which distribution(s)